linux-kernel - Re: [PATCH v5 11/14] trace: uprobes trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100622063428.GA15092@infradead.org>
Date:	Tue, 22 Jun 2010 02:34:28 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...e.hu>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Mel Gorman <mel@....ul.ie>,
	Randy Dunlap <rdunlap@...otime.net>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Roland McGrath <roland@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Christoph Hellwig <hch@...radead.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Mark Wielaard <mjw@...hat.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jim Keniston <jkenisto@...ux.vnet.ibm.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH v5 11/14] trace: uprobes trace_event interface

On Tue, Jun 22, 2010 at 09:45:29AM +0530, Srikar Dronamraju wrote:
> As you see UPROBE_EVENT is gated on UPROBES. I think if UPROBES is
> enabled, then UPROBE_EVENT should be enabled. Esp with Christoph
> suggesting for module support to be removed, I think it becomes all the
> more reason for UPROBE_EVENT to be enabled by default. Otherwise there
> is no point in having uprobes code and having no enabled users.
> I was even looking at "select UPROBE_EVENT" on enabling UPROBES.
> 
> Do you have any specific reason why UPROBE_EVENT should not be enabled
> by default? 

default y generally is a big hammer.  But given that it depends on
UPROBES it might be fine here.  Then again the big question is why
we even bother with separate config options?  At least in this form
UPROBES just is supported for UPROBE_EVENT.  So it makes sense either
to remove the UPROBES option entirely, or at least make it invisible
to the user and let UPROBE_EVENT select it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/