linux-kernel - Re: [PATCH] proc: Add complete process group list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100623090544.B588.A69D9226@jp.fujitsu.com>
Date:	Wed, 23 Jun 2010 09:10:13 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Mike McCormack <mikem@...g3k.org>
Cc:	kosaki.motohiro@...fujitsu.com, akpm@...ux-foundation.org,
	oleg@...hat.com, serue@...ibm.com, jmorris@...ei.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] proc: Add complete process group list

> If a process is in more than NGROUPS_SMALL (32) groups, it's not possible
>  for any other user space process to determine the list of groups it is
>  in using /proc/<pid>/status.
> 
> Increasing the list of groups listed by /proc/<pid>/status would lead to
>  very long lines that file, and possible misbehavior of userspace programs
>  that parse /proc/<pid>/status, so instead I have opted to create a new
>  file /proc/<pid>/groups, which contains the list of supplementary groups
>  for each pid.
> 
> The new file /proc/<pid>/groups consists of a single group id per line,
>  with each line being 11 characters long.  This should be enough space
>  for 16bit or 32bit group ids.
> 
> This feature might be useful for a server listening on a unix domain pipe
>  to determine the list of groups that a client process is in from its pid.
> 
> Signed-off-by: Mike McCormack <mikem@...g3k.org>

Just dumb question.

Why don't you fix /proc/<pid>/status? Can we share your worry? I haven't review your patch 
carefully yet. but your groups_proc_show() seems don't have heavy weight lock.

note: I'm not against your plan. it's just curiosity.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/