linux-kernel - Re: [PATCH 4/5] hid-input: Use a larger event buffer for MT devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1006231619570.13809@pobox.suse.cz>
Date:	Wed, 23 Jun 2010 16:20:49 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ping Cheng <pingc@...om.com>,
	Benjamin Tissoires <tissoire@...a.fr>,
	Chase Douglas <chase.douglas@...onical.com>,
	Rafi Rubin <rafi@...s.upenn.edu>
Subject: Re: [PATCH 4/5] hid-input: Use a larger event buffer for MT
 devices

On Wed, 23 Jun 2010, Henrik Rydberg wrote:

> The MT devices produce a lot of data. Tell the underlying input device
> approximately how many events will be sent per synchronization, to allow
> for better buffering. The number is a template based on continuously
> reporting details for each finger on a single hand.
> 
> Signed-off-by: Henrik Rydberg <rydberg@...omail.se>

Feel free to add

	Signed-off-by: Jiri Kosina <jkosina@...e.cz>

to any other further patch respins (if needed), or if actually applying 
this patch to any tree together with the rest of the series.

Thanks.

> ---
>  drivers/hid/hid-input.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 7a0d2e4..69d152e 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -534,6 +534,9 @@ mapped:
>  			input_set_abs_params(input, usage->code, a, b, (b - a) >> 8, (b - a) >> 4);
>  		else	input_set_abs_params(input, usage->code, a, b, 0, 0);
>  
> +		/* use a larger default input buffer for MT devices */
> +		if (usage->code == ABS_MT_POSITION_X && input->hint_events_per_packet == 0)
> +			input_set_events_per_packet(input, 60);
>  	}
>  
>  	if (usage->type == EV_ABS &&
> -- 
> 1.6.3.3
> 

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/