linux-kernel - Re: [PATCH] fbcon: deinline large static function get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Jun 2010 16:58:43 +0100 (BST)
From:	James Simmons <jsimmons@...radead.org>
To:	Denys Vlasenko <vda.linux@...glemail.com>
cc:	linux-fbdev@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbcon: deinline large static function get_color()


> This function's body is good two screenfuls and it has six callsites.
> No apparent reason why it is marked "iniline".
> 
> Signed-off-by: Denys Vlasenko <vda.linux@...glemail.com>

Signed-off-by: James Simmons <jsimmons@...radead.org>

> ---
>  drivers/video/console/fbcon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index b0a3fa0..24983e4 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -286,7 +286,7 @@ static inline int fbcon_is_inactive(struct vc_data *vc, struct fb_info *info)
>  		vc->vc_mode != KD_TEXT || ops->graphics);
>  }
>  
> -static inline int get_color(struct vc_data *vc, struct fb_info *info,
> +static int get_color(struct vc_data *vc, struct fb_info *info,
>  	      u16 c, int is_fg)
>  {
>  	int depth = fb_get_color_depth(&info->var, &info->fix);
> -- 
> 1.6.2.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/