linux-kernel - Re: [PATCH] scripts: checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100623122759.7bf304e6.akpm@linux-foundation.org>
Date:	Wed, 23 Jun 2010 12:27:59 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Raffaele Recalcati <lamiaposta71@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Raffaele Recalcati <raffaele.recalcati@...cino.it>,
	Andy Whitcroft <apw@...onical.com>,
	Daniel Walker <dwalker@...o99.com>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] scripts: checkpatch.pl

On Wed, 23 Jun 2010 11:49:21 +0200
Raffaele Recalcati <lamiaposta71@...il.com> wrote:

> From: Raffaele Recalcati <raffaele.recalcati@...cino.it>
> 
> I've got a false positive when spaces are present
> at the beginning of a line.
> So I add this check, obviously outside comments.
> This patch is compatible with the actual mainline,
> I mean 7e27d6e778cd87b6f2415515d7127eba53fe5d02 commit.

I don't really understand that.  It would help if the changelog
were to include a copy of the code which triggers this "false
positive", and a copy of the incorrect checkpatch output.

Thanks.

> Signed-off-by: Raffaele Recalcati <raffaele.recalcati@...cino.it>
> ---
>  scripts/checkpatch.pl |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a4d7434..315a827 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1433,6 +1433,13 @@ sub process {
>  			WARN("please, no space before tabs\n" . $herevet);
>  		}
>  
> +# check for spaces at the beginning of a line.
> +		if ($rawline =~ /^\+ / && $rawline !~ /\+ +\*/)  {
> +			my $herevet = "$here\n" . cat_vet($rawline) . "\n";
> +			WARN("please, no space for starting a line, \
> +				excluding comments\n" . $herevet);
> +		}
> +
>  # check we are in a valid C source file if not then ignore this hunk
>  		next if ($realfile !~ /\.(h|c)$/);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/