lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Jun 2010 23:35:35 +0200 From: Jiri Slaby <jirislaby@...il.com> To: Oleg Nesterov <oleg@...hat.com> CC: akpm@...ux-foundation.org, adobriyan@...il.com, nhorman@...driver.com, linux-kernel@...r.kernel.org, Stephen Smalley <sds@...ho.nsa.gov>, James Morris <jmorris@...ei.org>, Eric Paris <eparis@...isplace.org> Subject: Re: [PATCH v3 06/11] rlimits: do security check under task_lock On 06/23/2010 07:56 PM, Oleg Nesterov wrote: > On 06/23, Jiri Slaby wrote: >> I still see no way how this is wrong. We want to check whether current >> thread has capabilities to change (someone else's) rlimits. You know, this is one of those sentences where you wonder what kind of idiot wrote that. And then you find out it was you being totally off base. > Yes. but what is "someone else" ? I don't know what was I thinking of. Indeed you are correct. When I was writing that I was somehow under the impression (dunno why) that 'p' is current process and the code checks whether 'p' can do the change. But we are indeed checking whether 'current' may change 'p's limits -- or better, as you wrote, not of the thread 'p' itself, but of its whole process. I'll resend a new version with you all in CCs to see what we can do with the patches, if anything. thanks, -- js -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists