linux-kernel - Re: [PATCH 1/2] Staging: memrar: Moved memrar_allocator struct to memrar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0F091BB6-3DD4-48F2-B8AF-EDC02ECC4DE8@gmail.com>
Date:	Thu, 24 Jun 2010 12:27:43 +0300
From:	"Henri Häkkinen" <henrih81@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	gregkh@...e.de, ossama.othman@...el.com,
	Matti Lammi <mattij.lammi@...il.com>, randy.dunlap@...cle.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Staging: memrar: Moved memrar_allocator struct to memrar_allocator.c

On 24.6.2010, at 12.16, Alan Cox wrote:

>> +size_t memrar_allocator_largest_free_area(struct memrar_allocator *allocator)
>> +{
>> +	if (allocator == NULL)
>> +		return 0;
>> +	return allocator->largest_free_area;
>> +}
> 
> static ?

The entire point of these two patches was to hide the memrar_allocator structure by moving it to memrar_allocator.c, forward declaring it in memrar_allocator.h and then providing accessor functions memrar_allocator_largest_free_area and memrar_allocator_capacity (this was the #2 issue for memrar_allocator.[ch] in the TODO file). By defining memrar_allocator_largest_free_area function as static (this is what you mean, right?) would make no sense.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/