linux-kernel - Re: [PATCH 6/6 V4] input: STMPE touch controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100624123153.GB26189@bnru02.bnr.st.com>
Date:	Thu, 24 Jun 2010 18:01:53 +0530
From:	Rabin VINCENT <rabin.vincent@...ricsson.com>
To:	Luotao Fu <l.fu@...gutronix.de>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	STEricsson_nomadik_linux <STEricsson_nomadik_linux@...t.st.com>
Subject: Re: [PATCH 6/6 V4] input: STMPE touch controller support

On Thu, Jun 24, 2010 at 13:13:41 +0200, Luotao Fu wrote:
> +       adc_ctrl1 = SAMPLE_TIME(ts->sample_time) | MOD_12B(ts->mod_12b) |
> +               REF_SEL(ts->ref_sel);
> +       ret = stmpe_set_bits(stmpe, STMPE_REG_ADC_CTRL1,
> +                       adc_ctrl1, adc_ctrl1);
> +       if (ret) {
> +               dev_err(&pdev->dev, "Could not setup ADC\n");
> +               goto err_free_irq;
> +       }
> +
> +       ret = stmpe_set_bits(stmpe, STMPE_REG_ADC_CTRL2,
> +                       ADC_FREQ(ts->adc_freq), ADC_FREQ(ts->adc_freq));
> +       if (ret) {
> +               dev_err(&pdev->dev, "Could not setup ADC\n");
> +               goto err_free_irq;
> +       }
> +
> +       tsc_cfg = AVE_CTRL(ts->ave_ctrl) | DET_DELAY(ts->touch_det_delay) |
> +                       SETTLING(ts->settling);
> +       ret = stmpe_set_bits(stmpe, STMPE_REG_TSC_CFG, tsc_cfg, tsc_cfg);
> +       if (ret) {
> +               dev_err(&pdev->dev, "Could not config touch\n");
> +               goto err_free_irq;
> +       }
> +
> +       ret = stmpe_set_bits(stmpe, STMPE_REG_TSC_FRACTION_Z,
> +                       FRACTION_Z(ts->fraction_z),
> +                       FRACTION_Z(ts->fraction_z));

I think your earlier revisions had this same behaviour, but this only
writes the bits you are trying to set, and it may be a problem if there
are other bits already set in this field.  I don't know if this is a
concern with this block, but if it is, you can do something like the
following to clear out the field before writing:

stmpe_set_bits(stmpe, STMPE_REG_ADC_CTRL2,
	       ADC_FREQ(0xff), ADC_FREQ(ts->adc_freq));

or perhaps:

stmpe_set_bits(stmpe, STMPE_REG_ADC_CTRL2,
	       0xff, ADC_FREQ(ts->adc_freq));

Rabin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/