linux-kernel - Re: [RFC] [PATCH] timer: Added usleep[_range][

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C238D09.5050200@codeaurora.org>
Date:	Thu, 24 Jun 2010 09:51:21 -0700
From:	Patrick Pannuto <ppannuto@...eaurora.org>
To:	Andi Kleen <andi@...stfloor.org>
CC:	linux-kernel@...r.kernel.org, sboyd@...eaurora.org,
	tglx@...utronix.de, mingo@...e.hu, heiko.carstens@...ibm.com,
	eranian@...gle.com, schwidefsky@...ibm.com
Subject: Re: [RFC] [PATCH] timer: Added usleep[_range][_interruptable] timer

Andi Kleen wrote:
> Patrick Pannuto <ppannuto@...eaurora.org> writes:
> 
> Overall it seems like a good improvement.
> 
>> +
>> +static inline void usleep(unsigned long usecs)
>> +{
>> +	usleep_range(usecs, usecs);
>> +}
>> +
>> +static inline unsigned long usleep_interruptible(unsigned long usecs)
> 
> Is the interruptible case even needed?  I assume most drivers won't
> bother with that and not being interruptible for a few usecs is not a
> big issue.

Honestly, I don't think so, but I was mirroring the msleep API when
I wrote it so I included it for completeness.  I can't think of a use
case where it is necessary / useful. I will remove it unless anyone
can think of an application for it?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/