linux-kernel - Re: [PATCH] - irq vector assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTilTpJuwL52d-u-iYYnh6nw5qYQgLYRt7zdcjktp@mail.gmail.com>
Date:	Thu, 24 Jun 2010 13:45:40 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Jack Steiner <steiner@....com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	"H. Peter Anvin" <hpa@...or.com>
Cc:	mingo@...e.hu, tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] - irq vector assignment

On Thu, Jun 24, 2010 at 12:34 PM, Jack Steiner <steiner@....com> wrote:
> Try to assign irqs to cpus on the correct node & fall back to global
> assignment only if node-local fails. This reduces the chances of
> using all of the interrupt vectors of a single cpu.
>
> Signed-off-by: Jack Steiner <steiner@....com>
>
>
> ---
>  arch/x86/kernel/apic/io_apic.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> Index: linux/arch/x86/kernel/apic/io_apic.c
> ===================================================================
> --- linux.orig/arch/x86/kernel/apic/io_apic.c   2010-06-24 12:58:11.658933610 -0500
> +++ linux/arch/x86/kernel/apic/io_apic.c        2010-06-24 13:56:26.734380290 -0500
> @@ -3259,7 +3259,9 @@ unsigned int create_irq_nr(unsigned int
>                desc_new = move_irq_desc(desc_new, node);
>                cfg_new = desc_new->chip_data;
>
> -               if (__assign_irq_vector(new, cfg_new, apic->target_cpus()) == 0)
> +               if (node >= 0 && __assign_irq_vector(new, cfg_new, node_to_cpumask_map[node]) == 0)
> +                       irq = new;
> +               else if (__assign_irq_vector(new, cfg_new, apic->target_cpus()) == 0)
>                        irq = new;
>                break;
>        }

how about update apic::target_cpus() to take node?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/