linux-kernel - Re: [PATCH] staging/spectra: remove non existing blk_fs_request wrapper

Open Source and information security mailing list archives

Message-Id: <20100625084312.8199b158.randy.dunlap@oracle.com>
Date:	Fri, 25 Jun 2010 08:43:12 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Javier Martinez Canillas <martinez.javier@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	David Woodhouse <David.Woodhouse@...el.com>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] staging/spectra: remove non existing blk_fs_request
 wrapper

On Fri, 25 Jun 2010 00:40:48 -0400 Javier Martinez Canillas wrote:

> The spectra driver doesn't compile with today linux-next
> 
> The problem is that it tries to use a blk_fs_request macro. Searching for this macro I saw that it used to exist in linux/blkdev.h as
> 
> #define blk_fs_request(rq) ((rq)->cmd_type == REQ_TYPE_FS)
> 
> This patch solves the issue eliminating the unnecessary (and now inexistent) wrapper
> 
> Best regards,
> 
> >From 755f948d65ff67d5dc8dde8c2edd212cbe61bd5f Mon Sep 17 00:00:00 2001
> From: Javier Martinez Canillas <martinez.javier@...il.com>
> Date: Fri, 25 Jun 2010 00:26:20 -0400
> Subject: [PATCH] staging/spectra: remove non existing blk_fs_request wrapper
> 
> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier@...il.com>

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

Thanks.

> ---
>  drivers/staging/spectra/ffsport.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/spectra/ffsport.c b/drivers/staging/spectra/ffsport.c
> index 3c3565d..d0c5c97 100644
> --- a/drivers/staging/spectra/ffsport.c
> +++ b/drivers/staging/spectra/ffsport.c
> @@ -304,7 +304,7 @@ static int do_transfer(struct spectra_nand_dev *tr, struct request *req)
>  			return 0;
>  	}
>  
> -	if (!blk_fs_request(req))
> +	if (req->cmd_type != REQ_TYPE_FS)
>  		return -EIO;
>  
>  	if (blk_rq_pos(req) + blk_rq_cur_sectors(req) > get_capacity(tr->gd)) {
> -- 
> 1.7.0.4
> 
> 
> 
> 
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives