linux-kernel - Re: [PATCH] of/flattree: Use common ALIGN() macro instead of archspecific

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTik5MsUycP_OVJyr__zbCeqIsKvkhc8MoAdco5En@mail.gmail.com>
Date:	Fri, 25 Jun 2010 17:46:52 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Stephen Neuendorffer <stephen.neuendorffer@...inx.com>
Cc:	benh@...nel.crashing.org, monstr@...str.eu,
	microblaze-uclinux@...e.uq.edu.au,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	jeremy.kerr@...onical.com, sfr@...b.auug.org.au
Subject: Re: [PATCH] of/flattree: Use common ALIGN() macro instead of 
	archspecific _ALIGN

On Fri, Jun 25, 2010 at 5:36 PM, Stephen Neuendorffer
<stephen.neuendorffer@...inx.com> wrote:
>
>
>> -----Original Message-----
>> From: glikely@...retlab.ca [mailto:glikely@...retlab.ca] On Behalf Of Grant Likely
>> Sent: Friday, June 25, 2010 4:34 PM
>> To: Stephen Neuendorffer
>> Cc: benh@...nel.crashing.org; monstr@...str.eu; microblaze-uclinux@...e.uq.edu.au; devicetree-
>> discuss@...ts.ozlabs.org; linux-kernel@...r.kernel.org; jeremy.kerr@...onical.com;
>> sfr@...b.auug.org.au
>> Subject: Re: [PATCH] of/flattree: Use common ALIGN() macro instead of archspecific _ALIGN
>>
>> On Fri, Jun 25, 2010 at 5:18 PM, Stephen Neuendorffer
>> <stephen.neuendorffer@...inx.com> wrote:
>> >> -----Original Message-----
>> >> From: glikely@...retlab.ca [mailto:glikely@...retlab.ca] On Behalf Of Grant Likely
>> >> Sent: Friday, June 25, 2010 4:16 PM
>> >> To: Stephen Neuendorffer
>> >> Cc: benh@...nel.crashing.org; monstr@...str.eu; microblaze-uclinux@...e.uq.edu.au; devicetree-
>> >> discuss@...ts.ozlabs.org; linux-kernel@...r.kernel.org; jeremy.kerr@...onical.com;
>> >> sfr@...b.auug.org.au
>> >> Subject: Re: [PATCH] of/flattree: Use common ALIGN() macro instead of archspecific _ALIGN
>> >>
>> >> On Fri, Jun 25, 2010 at 4:49 PM, Stephen Neuendorffer
>> >> <stephen.neuendorffer@...inx.com> wrote:
>> >> > Grant,
>> >> >
>> >> > I need this for the PCI project.  I also have a couple of other
>> >> > generalizations of the drivers/of code
>> >> > to get it to run after boot time in an X86 system...
>> >>
>> >> Send me your patches!  :-)  Get them to me soon and I'll queue them up
>> >> for the next merge window.
>> >>
>> >> g.
>> >
>> > Dangit, I just got the code compiling, and now I find out that X86 doesn't support out_be32()...  :)
>> > You'd think that somewhere somebody might have realized that all the duplicated driver macros that
>> > do that are a bad idea...
>>
>> :-)
>>
>> I think iowrite32be should be cross-arch safe.  in_*, out_* was mostly
>> a powerpc/sparc thing.
>>
>> g.
>
> See.. I told you it was a good idea to have that abstracted.. :)

'course the real problem is not the access macros, but rather the fact
that sometime the xilinx registers are wired up as big-endian, and
sometimes as little-endian.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/