linux-kernel - Re: [PATCH] arch/tile: Miscellaneous cleanup changes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 26 Jun 2010 11:56:28 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Chris Metcalf <cmetcalf@...era.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch/tile: Miscellaneous cleanup changes.

On Friday 25 June 2010, Chris Metcalf wrote:
> This commit is primarily changes caused by reviewing "sparse"
> and "checkpatch" output on our sources, so is somewhat noisy, since
> things like "printk() -> pr_err()" (or whatever) throughout the
> codebase tend to get tedious to read.  Rather than trying to tease
> apart precisely which things changed due to which type of code
> review, this commit includes various cleanups in the code:
> 
> - sparse: Add declarations in headers for globals.
> - sparse: Fix __user annotations.
> - sparse: Using gfp_t consistently instead of int.
> - sparse: removing functions not actually used.
> - checkpatch: Clean up printk() warnings by using pr_info(), etc.;
>   also avoid partial-line printks except in bootup code.
>   - checkpatch: Use exposed structs rather than typedefs.
>   - checkpatch: Change some C99 comments to C89 comments.
> 
> In addition, a couple of minor other changes are rolled in
> to this commit:
> 
> - Add support for a "raise" instruction to cause SIGFPE, etc., to be raised.
> - Remove some compat code that is unnecessary when we fully eliminate
>   some of the deprecated syscalls from the generic syscall ABI.
> - Update the tile_defconfig to reflect current config contents.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@...era.com>

Hi Chris,

As far as I can tell, all the changes in this patch look reasonable, but
as a rule you should never mix functional changes and cleanups in a single
patch. This is both for review purposes as well as for being able to bisect
specific regressions that might be introduced by the patch.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/