linux-kernel - Re: [2.6.33.4 PATCH] V4L/uvcvideo: Add support for Suyin Corp. Lenovo Webcam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100626103615.GE8384@localhost>
Date:	Sat, 26 Jun 2010 12:36:15 +0200
From:	Nils Radtke <Nils.Radtke@...nk-Future.de>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	stable@...nel.org
Subject: Re: [2.6.33.4 PATCH] V4L/uvcvideo: Add support for Suyin Corp.
 Lenovo Webcam

  Hi Laurent,

On ven 2010-06-25 @ 09-29-28 +0200, Laurent Pinchart wrote: 
# Hi Nils,
# 
# On Thursday 24 June 2010 20:19:41 Nils Radtke wrote:
# > On Wed 2010-06-23 @ 02-45-53PM +0200, Laurent Pinchart wrote:
# > # On Wednesday 23 June 2010 11:23:16 Nils Radtke wrote:
# > # > From: Nils Radtke <lkml@...nk-Future.de>
# > # >
# > # > This patch adds support for the Suyin Corp. Lenovo Webcam.
# > # > lsusb: ID 064e:a102 Suyin Corp. Lenovo Webcam
# > # >
# > # > It is available as built-in webcam i.e. in ACER timeline 1810t
# > # > notebooks.
# > # >
# > # > The note in uvc_driver.c about Logitech cameras applies the same
# > # > to the Suyin web cam: it doesn't announce itself as UVC devices
# > # > but is compliant.
# > # >
# > # > Signed-off-by: Nils Radtke <lkml@...nk-Future.de>
# > #
# > # Thanks for the patch. Could you please send me the output of lsusb -v for
# > your
# > 
# > Bus 002 Device 002: ID 064e:a102 Suyin Corp. Lenovo Webcam
# 
# [snip]
# 
# >     Interface Descriptor:
# >       bLength                 9
# >       bDescriptorType         4
# >       bInterfaceNumber        0
# >       bAlternateSetting       0
# >       bNumEndpoints           1
# >       bInterfaceClass        14 Video
# >       bInterfaceSubClass      1 Video Control
# >       bInterfaceProtocol      0
# >       iInterface              5 Webcam
# 
# This looks like a pretty standard UVC device. Are you sure your patch is 
# needed ?
Indeed. Hm, about whether the patch is needed.. What happened here was: the module
didn't get loaded w/o the patch. But then maybe something else made the change? 
After subsequent reboot the module did get loaded. Hm..

Isn't the vendor/product ID a point of reference that tells the kernel which module
to load when supported hw is found? That was the idea behind adding the ID and
submitting the patch. 

Thanks for clarification.

        Cheers, 

                  Nils

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/