linux-kernel - Re: [PATCH] fbdev: section cleanup in viafb driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 26 Jun 2010 10:31:09 +0800
From:	"coffbeta" <coffbeta@...il.com>
To:	"Henrik Kretzschmar" <henne@...htwindheim.de>,
	"Andy Shevchenko" <ext-andriy.shevchenko@...ia.com>,
	"Andy Shevchenko" <andy.shevchenko@...il.com>,
	"Jason Wessel" <jason.wessel@...driver.com>,
	"kgdb-bugreport" <kgdb-bugreport@...ts.sourceforge.net>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"Martin Hicks" <mort@....com>
Subject: Re: [PATCH] fbdev: section cleanup in viafb driver

             -static void __devexit via_teardown_subdevs(void)
------------------				 
coffbeta
2010-06-26

-------------------------------------------------------------
发件人：Henrik Kretzschmar
发送日期：2010-06-17 18:09:34
收件人：JosephChan; ScottFang
抄送：corbet; FlorianSchandinat; linux-fbdev; linux-kernel; Henrik Kretzschmar
主题：[PATCH] fbdev: section cleanup in viafb driver

This patch moves two functions from .devexit to .text,
which are called on the probe error path.
Also a function which is called by probe is moved
from .text to .devinit.

WARNING: vmlinux.o(.devinit.text+0x2ca5): Section mismatch in reference
from the function via_pci_probe() to the function
.devexit.text:via_teardown_subdevs()
The function __devinit via_pci_probe() references
a function __devexit via_teardown_subdevs().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
via_teardown_subdevs() so it may be used outside an exit section.

WARNING: vmlinux.o(.devinit.text+0x2cb1): Section mismatch in reference
from the function via_pci_probe() to the function
.devexit.text:via_pci_teardown_mmio()
The function __devinit via_pci_probe() references
a function __devexit via_pci_teardown_mmio().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
via_pci_teardown_mmio() so it may be used outside an exit section.

Signed-off-by: Henrik Kretzschmar <henne@...htwindheim.de>
---
This patch is compile tested against Linus lastest git kernel.

 drivers/video/via/via-core.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/via/via-core.c b/drivers/video/via/via-core.c
index e8cfe83..ec2e5aa 100644
--- a/drivers/video/via/via-core.c
+++ b/drivers/video/via/via-core.c
@@ -64,7 +64,7 @@ static inline int viafb_mmio_read(int reg)
  */
 static u32 viafb_enabled_ints;

-static void viafb_int_init(void)
+static void __devinit viafb_int_init(void)
 {
 	viafb_enabled_ints = 0;

@@ -489,7 +489,7 @@ out_unmap:
 	return ret;
 }

-static void __devexit via_pci_teardown_mmio(struct viafb_dev *vdev)
+static void via_pci_teardown_mmio(struct viafb_dev *vdev)
 {
 	iounmap(vdev->fbmem);
 	iounmap(vdev->engine_mmio);
@@ -548,7 +548,7 @@ static int __devinit via_setup_subdevs(struct viafb_dev *vdev)
 	return 0;
 }

-static void __devexit via_teardown_subdevs(void)
+static void via_teardown_subdevs(void)
 {
 	int i;

-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/