linux-kernel - Re: [PATCH 1/2] block: fix leaks associated with discard request payload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100627153545.GC25667@lst.de>
Date:	Sun, 27 Jun 2010 17:35:45 +0200
From:	Christoph Hellwig <hch@....de>
To:	Mike Snitzer <snitzer@...hat.com>
Cc:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>, hch@....de,
	axboe@...nel.dk, dm-devel@...hat.com, James.Bottomley@...e.de,
	linux-kernel@...r.kernel.org, martin.petersen@...cle.com,
	akpm@...ux-foundation.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH 1/2] block: fix leaks associated with discard request payload

On Sun, Jun 27, 2010 at 10:16:40AM -0400, Mike Snitzer wrote:
> My leak fixes have been tested extensively against all permuations of
> devices with discards (ATA trim, SCSI UNMAP, SCSI WRTIE SAME w/ unmap=1).
> 
> I think we need to get Christoph's discard payload transformation
> complete by fixing the leaks _without_ trying to rework how discard
> commands are tagged, etc.  E.g. fix what Jens already has staged in
> linux-2.6-block's 'for-next' and 'for-2.6.36'.
> 
> With that sorted out we can then look at longer term changes to cleanup
> discard request processing.

I tend to agree.  I'll look into getting rid of treating discards as
BLOCK_PC commands ontop of you patchset.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/