linux-kernel - Re: [PATCH 1/5]security:key.c Fix warning: variable 'key' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5104.1277728717@redhat.com>
Date:	Mon, 28 Jun 2010 13:38:37 +0100
From:	David Howells <dhowells@...hat.com>
To:	"Justin P. Mattock" <justinmattock@...il.com>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	sds@...ho.nsa.gov, lenb@...nel.org, linux-bluetooth@...r.kernel.org
Subject: Re: [PATCH 1/5]security:key.c Fix warning: variable 'key' set but not used 

Justin P. Mattock <justinmattock@...il.com> wrote:

> In this case the safest approach(in my mind) would be to just
> mark the integer __unused. Keep in mind though Im not certain 
> if this is the right place for this value i.e. will this effect
> *instkey or not(please check).

This is the wrong approach.  Either the variable should be got rid of, or it
should be used to replace all the other calls to key_ref_to_ptr() in
keyctl_describe_key().

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/