lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Jun 2010 14:52:24 +0200 From: Dan Carpenter <error27@...il.com> To: Kulikov Vasiliy <segooon@...il.com> Cc: trivial@...nel.org, Kernel Janitors <kernel-janitors@...r.kernel.org>, Greg Kroah-Hartman <gregkh@...e.de>, Henk de Groot <pe1dnn@...at.org>, Joe Perches <joe@...ches.com>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 15/16] trivial: use ARRAY_SIZE On Mon, Jun 28, 2010 at 03:55:41PM +0400, Kulikov Vasiliy wrote: > Change sizeof(x) / sizeof(*x) to ARRAY_SIZE(x). > > Signed-off-by: Kulikov Vasiliy <segooon@...il.com> > --- > drivers/staging/wlags49_h2/hcf.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/wlags49_h2/hcf.c b/drivers/staging/wlags49_h2/hcf.c > index 390628c..c4fe0ec 100644 > --- a/drivers/staging/wlags49_h2/hcf.c > +++ b/drivers/staging/wlags49_h2/hcf.c > @@ -502,7 +502,7 @@ HCF_STATIC hcf_16* BASED xxxx[ ] = { > #endif // MSF_COMPONENT_ID > NULL //endsentinel > }; > -#define xxxx_PRI_IDENTITY_OFFSET (sizeof(xxxx)/sizeof(xxxx[0]) - 3) > +#define xxxx_PRI_IDENTITY_OFFSET (ARRAY_SIZE(xxxx) - 3) > I would say the more critical problem with this macro is that it doesn't work unless you name all your arrays "xxxx[]" so it encourages sub par variable names. You could do: #define PRI_IDENTITY_OFFSET(x) (ARRAY_SIZE(x) - 3) regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists