| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LRH.2.00.1006290901400.5933@tundra.namei.org> Date: Tue, 29 Jun 2010 09:01:52 +1000 (EST) From: James Morris <jmorris@...ei.org> To: David Howells <dhowells@...hat.com> cc: linux-security-module@...r.kernel.org, keyrings@...ux-nfs.org, linux-kernel@...r.kernel.org, justinmattock@...il.com Subject: Re: [Keyrings] [PATCH] KEYS: Use the variable 'key' in keyctl_describe_key() On Mon, 28 Jun 2010, David Howells wrote: > keyctl_describe_key() turns the key reference it gets into a usable key pointer > and assigns that to a variable called 'key', which it then ignores in favour of > recomputing the key pointer each time it needs it. Make it use the precomputed > pointer instead. > > Without this patch, gcc 4.6 reports that the variable key is set but not used: > > building with gcc 4.6 I'm getting a warning message: > CC security/keys/keyctl.o > security/keys/keyctl.c: In function 'keyctl_describe_key': > security/keys/keyctl.c:472:14: warning: variable 'key' set but not used > > Reported-by: Justin P. Mattock <justinmattock@...il.com> > Signed-off-by: David Howells <dhowells@...hat.com> Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next -- James Morris <jmorris@...ei.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists