lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Jun 2010 01:02:35 -0700 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Axel Lin <axel.lin@...il.com> Cc: linux-kernel <linux-kernel@...r.kernel.org>, Miloslav Trmac <mitr@...ny.cz>, Rakib Mullick <rakib.mullick@...il.com>, TJ <ubuntu@...orld.net>, Julia Lawall <julia@...u.dk>, Samu Onkalo <samu.p.onkalo@...ia.com>, linux-input@...r.kernel.org Subject: Re: [PATCH] wistron_btns: fix a memory leak in wb_module_init error path Hi Axel, On Mon, Jun 28, 2010 at 02:30:20PM +0800, Axel Lin wrote: > select_keymap calls copy_keymap to allocate a memory for keymap. > This patch adds a missing kfree(keymap) in wb_module_init error path. > > Signed-off-by: Axel Lin <axel.lin@...il.com> > --- > drivers/input/misc/wistron_btns.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/input/misc/wistron_btns.c b/drivers/input/misc/wistron_btns.c > index 4dac8b7..55ce70e 100644 > --- a/drivers/input/misc/wistron_btns.c > +++ b/drivers/input/misc/wistron_btns.c > @@ -1371,6 +1371,7 @@ static int __init wb_module_init(void) > platform_driver_unregister(&wistron_driver); > err_unmap_bios: > unmap_bios(); > + kfree(keymap); Thank you for the patch, however this is not quite enough - we also need to free keymap when map_bios() call fails instead of returning immediately. I fixed up locally and applied the patch. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists