linux-kernel - Re: [PATCH] dynamic_debug: allow to set dynamic debug flags right at module load time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201006291325.29983.roman.fietze@telemotive.de>
Date:	Tue, 29 Jun 2010 13:25:29 +0200
From:	Roman Fietze <roman.fietze@...emotive.de>
To:	Jason Baron <jbaron@...hat.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dynamic_debug: allow to set dynamic debug flags right at module load time

Hello Jason, hello LKML,

On Friday 28 May 2010 15:55:49 Jason Baron wrote:

> right, i think we want to add something inside ddebug_add_module()
> that recognizes if the module was loaded with verbose=1. I think you
> can get at the parameters via module->kp, which we need to pass in
> as well.

Yes, I would first check if there's a section named "__verbose" as it
is right now. If yes, I would search the already setup module->kp for
the used parameter.

Proposals, not being sure how to implement that right now:

Default is to search e.g. for param "dprintk".

Provide a macro to override that default, e.g.
DPRINTK_PARAM("verbose")

If the default or defined bool or other integer parameter is unequal
to 0 enable the p-flag on module load for all debug statements of this
module.

Questions just in case the proposal is kind of ok:

Prepare the code to allow the setting of different future flags
unequal to 'p'?

Use a charp param instead of a bool to allow that?

Roman

-- 
Roman Fietze              Telemotive AG Buero Muehlhausen
Breitwiesen                             73347 Muehlhausen
Tel.: +49(0)7335/18493-45        http://www.telemotive.de
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/