[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4C294A1E.1070602@cn.fujitsu.com>
Date: Tue, 29 Jun 2010 09:19:26 +0800
From: Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To: Avi Kivity <avi@...hat.com>
CC: Marcelo Tosatti <mtosatti@...hat.com>,
LKML <linux-kernel@...r.kernel.org>,
KVM list <kvm@...r.kernel.org>
Subject: Re: [PATCH v2 1/10] KVM: MMU: fix writable sync sp mapping
Avi Kivity wrote:
>
>
> I think I see. So, after A, the pages are write protected, but are
> still marked as unsync. In B, we're testing SP2->unsync, which we plan
> to sync soon, but haven't yet. So the test for s->unsync is incorrect.
>
Right.
> So the patch is right. Thanks for the explanation. Please update the
> changelog to note that sp->unsync is not reliable during resync, this is
> tricky stuff.
>
OK, will do it in the next version.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists