linux-kernel - Re: [PATCH 01/25] r852: remove casts from void*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Jun 2010 19:28:26 +0400
From:	Kulikov Vasiliy <segooon@...il.com>
To:	Dan Carpenter <error27@...il.com>,
	Kernel Janitors <kernel-janitors@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/25] r852: remove casts from void*

> 1) The subjects are not helpful.  This one should say something about
> "mtd" but it doesn't.
ok

> 2) These haven't been run through checkpatch.pl.
Sorry for dummy question, but shouldn't code style be consistent?
Somebody who will see old code and patched code will see one line with
wrong-style code then one line with ok then one with wrong etc.
Imho it's better to fix style in one big patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/