linux-kernel - Re: [PATCH 3/3] Add a pair of system calls to make extended file stats available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100629224844.GF4150@mail.oracle.com>
Date:	Tue, 29 Jun 2010 15:48:44 -0700
From:	Joel Becker <Joel.Becker@...cle.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Ulrich Drepper <drepper@...il.com>, viro@...iv.linux.org.uk,
	smfrench@...il.com, jlayton@...hat.com, mcao@...ibm.com,
	aneesh.kumar@...ux.vnet.ibm.com, linux-cifs@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	samba-technical@...ts.samba.org, sjayaraman@...e.de,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 3/3] Add a pair of system calls to make extended file
 stats available

On Tue, Jun 29, 2010 at 11:36:56PM +0100, David Howells wrote:
> Ulrich Drepper <drepper@...il.com> wrote:
> > And while you're at it, maybe some spare fields at the end are nice.
> 
> I made it so that the syscall can return variable length data: the main xstat
> struct, plus extra records yet to be defined.  They could even be variable
> length and assembled/disassembled with something like the control message
> macros for recvmsg().

	The less variable length stuff the better, I think.  At least,
for the stuff stat(2) already returns, you should have a fixed-size
structure.  Even if I only pass the GIVE_ME_UIDS flag, I don't want to
have to deal with the variable size stuff until I've actually asked for
esoteric things.  I'll know that the non-UIDS fields are garbage by the
fact that I didn't ask for them.

Joel

-- 

"Time is an illusion, lunchtime doubly so."
        -Douglas Adams

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker@...cle.com
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/