lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <1277887844.2474.122.camel@tubuntu.research.nokia.com>
Date:	Wed, 30 Jun 2010 11:50:44 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...ia.com>
To:	ext Afzal Mohammed <lazfamam@...il.com>
Cc:	"Syrjala Ville (Nokia-D/Helsinki)" <ville.syrjala@...ia.com>,
	"tj@...nel.org" <tj@...nel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] OMAP2:OMAPFB: Fix error path

Hi,

Please send the patch as plaintext, without any HTML content.

Also, use the same patch subject as other patches for omapfb, in this
case "OMAP: DSS2: OMAPFB: ...", and include a bit more verbose
description.

 Tomi


On Tue, 2010-06-29 at 22:29 +0200, ext Afzal Mohammed wrote:
> 
> 
> sysfs file removed in error path of omapfb_create_framebuffers()
> 
> 
> Signed-off-by: Afzal Mohammed <lazfamam@...il.com>
> ---
>  drivers/video/omap2/omapfb/omapfb-main.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c
> b/drivers/video/omap2/omapfb/omapfb-main.c
> index 4b4506d..2319b81 100644
> --- a/drivers/video/omap2/omapfb/omapfb-main.c
> +++ b/drivers/video/omap2/omapfb/omapfb-main.c
> @@ -1945,6 +1945,7 @@ static int omapfb_create_framebuffers(struct
> omapfb2_device *fbdev)
>   r = omapfb_overlay_enable(ovl, 1);
>  
>   if (r) {
> + omapfb_remove_sysfs(fbdev);
>   dev_err(fbdev->dev,
>   "failed to enable overlay\n");
>   return r;
> -- 
> 1.7.0.4
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ