linux-kernel - Re: [PATCH 3/9] Removing dead CONFIG_SIBYTE_BCM1480

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1006301133400.13809@pobox.suse.cz>
Date:	Wed, 30 Jun 2010 11:36:53 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	Christoph Egger <siccegge@...fau.de>,
	Gilles Espinasse <g.esp@...e.fr>, Tejun Heo <tj@...nel.org>,
	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
	vamos@...informatik.uni-erlangen.de
Subject: Re: [PATCH 3/9] Removing dead CONFIG_SIBYTE_BCM1480_PROF

On Mon, 28 Jun 2010, Ralf Baechle wrote:

> > > CONFIG_SIBYTE_BCM1480_PROF doesn't exist in Kconfig, therefore removing all
> > > references for it from the source code.
> > 
> > The patch isn't present in linux-next as of today. I have applied it to my 
> > tree, thanks.
> 
> Nack.  This only need to be rewired to use the ZBus profiler just like
> the SB1250 already does.  It's the virtually same hardware after all!

Well, still it's dead code guarded by ifdef depending on non-exsiting 
symbol ... I have just quickly tried to get a grip on the zbus thing, but

	arch/mips/configs/bigsur_defconfig:CONFIG_SIBYTE_HAS_ZBUS_PROFILING=y
	arch/mips/configs/sb1250-swarm_defconfig:CONFIG_SIBYTE_HAS_ZBUS_PROFILING=y
	1arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       select SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:       depends on SIBYTE_HAS_ZBUS_PROFILING
	arch/mips/sibyte/Kconfig:config SIBYTE_HAS_ZBUS_PROFILING

seem to be the only occurences in the whole tree. Another unused symbol?

So I'll revert that patch in my tree as it has been nacked by maintainer, 
but the feeling that cleanup is needed is still there.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/