linux-kernel - Re: [PATCH]kernel.h Fix #warning message web address.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100630142259.a5f4dcb5.rdunlap@xenotime.net>
Date:	Wed, 30 Jun 2010 14:22:59 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	"Justin P. Mattock" <justinmattock@...il.com>
Cc:	Jiri Kosina <jkosina@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]kernel.h Fix #warning message web address.

On Wed, 30 Jun 2010 14:20:42 -0700 Justin P. Mattock wrote:

> 
> > Hehe, ugly. How about making it a single string? GCC preprocessor
> > documentation suggests the same anyway ...
> >
> > 	Neither `#error' nor `#warning' macro-expands its argument.
> > 	Internal whitespace sequences are each replaced with a single space.
> > 	The line must consist of complete tokens.  It is wisest to make the
> > 	argument of these directives be a single string constant; this avoids
> > 	problems with apostrophes and the like.

Doesn't that mean just put double quotation marks around the entire message string??



> o.k. jiri, here is what I came up with, after re-reading and looking at 
> other in the kernel(below).
> 
> 
> 
>  From 45f24db45faa06aad01cfc62ff4b475380e5cb11 Mon Sep 17 00:00:00 2001
> From: Justin P. Mattock <justinmattock@...il.com>
> Date: Wed, 30 Jun 2010 14:06:18 -0700
> Subject: [PATCH]kernel.h Fix #warning message according to the GCC 
> preprocessor docs.
> 
> received this #warning from a simple printk program and noticed the web
> address is not showing up:
>   gcc printk.c -o printk
> In file included from printk.c:3:
> include/linux/kernel.h:733:2: warning: #warning Attempt to use kernel 
> headers from user space, see http:
> 
> after the changes the warning should just say:
> #warning Attempt to use kernel headers from user space!
> 
>   Signed-off-by: Justin P. Mattock <justinmattock@...il.com>
> ---
>   include/linux/kernel.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> index 8317ec4..b542961 100644
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -730,7 +730,7 @@ extern int do_sysinfo(struct sysinfo *info);
> 
>   #ifndef __EXPORTED_HEADERS__
>   #ifndef __KERNEL__
> -#warning Attempt to use kernel headers from user space, see 
> http://kernelnewbies.org/KernelHeaders
> +#warning Attempt to use kernel headers from user space!
>   #endif /* __KERNEL__ */
>   #endif /* __EXPORTED_HEADERS__ */
> 
> -- 
> 1.7.1.rc1.21.gf3bd6
> 
> 
> now I'm wondering if there should be a lead to the documentation with 
> this web address(seems grep is not finding anything that I might be able 
> to use).or just leave as is, and let people connect-the-dots!!
> 
> let me know..
> 
> Justin P. Mattock
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/