linux-kernel - Re: [PATCH] ext2:delete misused ext2_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Jul 2010 00:57:54 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Peter Pan <wppan@...flag-linux.com>
Cc:	jack@...e.cz, hch@....de, viro@...iv.linux.org.uk, npiggin@...e.de,
	jblunck@...e.de, linux-fsdevel@...r.kernel.org,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ext2:delete misused ext2_free_blocks

On Wed, Jun 30, 2010 at 06:21:27PM +0800, Peter Pan wrote:
> if ext2_new_blocks returns error, no blocks need to be freed.
> 

Hi Peter,

Your patch isn't right.  The original code is OK as is.

Are you seeing a kernel panic?  Perhaps we can help you fix it.

regards,
dan carpenter

> Signed-off-by: Peter Pan <wppan@...flag-linux.com>
> ---
>  fs/ext2/inode.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index 3675088..f858847 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -385,6 +385,8 @@ static int ext2_alloc_blocks(struct inode *inode,
>  	ext2_fsblk_t current_block = 0;
>  	int ret = 0;
>  
> +	*err = -ENOSPC;
> +
>  	/*
>  	 * Here we try to allocate the requested multiple blocks at once,
>  	 * on a best-effort basis.
> @@ -421,8 +423,6 @@ static int ext2_alloc_blocks(struct inode *inode,
>  	*err = 0;
>  	return ret;
>  failed_out:
> -	for (i = 0; i <index; i++)
> -		ext2_free_blocks(inode, new_blocks[i], 1);
>  	return ret;
>  }
>  
> -- 
> 1.6.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/