linux-kernel - Re: [PATCH]kernel.h Move warning message about using kernel headers for userspace to types.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201007010958.46720.arnd@arndb.de>
Date:	Thu, 1 Jul 2010 09:58:46 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	"Justin P. Mattock" <justinmattock@...il.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	jkosina@...e.cz
Subject: Re: [PATCH]kernel.h Move warning message about using kernel headers for userspace to types.h

On Thursday 01 July 2010 00:09:45 Justin P. Mattock wrote:
> Hopefully correct, as request move the function that checks
> if userspace is using kernel headers, from kernel.h to types.h.
> (Please check.)
> 
>  Signed-off-by: Justin P. Mattock <justinmattock@...il.com>

Trivial change: The 'Signed-off-by'-line should start at the beginning
of the line, no space in front of it, to make all tools parse
it correctly.

Also, the text above should really be the changelog in the way
that you want it to appear in the git history. The explanatory
text about what has changed can go below the '---' line, together
with the diffstat information. Git only uses text above the line
as a changeset comment.

> --- a/include/linux/types.h
> +++ b/include/linux/types.h
> @@ -179,6 +179,12 @@ typedef __u32 __bitwise __wsum;
>  typedef unsigned __bitwise__ gfp_t;
>  typedef unsigned __bitwise__ fmode_t;
>  
> +#ifndef __EXPORTED_HEADERS__
> +#ifndef __KERNEL__
> +#warning "Attempt to use kernel headers from user space, see http://kernelnewbies.org/KernelHeaders"
> +#endif /* __KERNEL__ */
> +#endif /* __EXPORTED_HEADERS__ */
> +
>  #ifdef CONFIG_PHYS_ADDR_T_64BIT
>  typedef u64 phys_addr_t;

Good: No more linewrap, correct use of quotation marks.
Bad: This is now inside of #ifdef __KERNEL__, so it can never be caught by
the compiler. Even if it looks like a trivial patch, it's a good idea
to test it.

I'd suggest putting the #ifndef __EXPORTED_HEADERS__ into a new #else
path of the last #ifdef __KERNEL__ of this file.

Anyway, thanks for the persistence, I know it's frustrating when a one-line
change goes through half a dozen revisions.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/