linux-kernel - Re: [PATCH] KEYS: Reinstate lost passing of process keyring ID in call_sbin_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1007011019060.23781@tundra.namei.org>
Date:	Thu, 1 Jul 2010 10:19:24 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	David Howells <dhowells@...hat.com>
cc:	linux-security-module@...r.kernel.org, keyrings@...ux-nfs.org,
	linux-kernel@...r.kernel.org,
	"Justin P. Mattock" <justinmattock@...il.com>
Subject: Re: [PATCH] KEYS: Reinstate lost passing of process keyring ID in
 call_sbin_request_key()

On Wed, 30 Jun 2010, David Howells wrote:

> From: Justin P. Mattock <justinmattock@...il.com>
> 
> In commit bb952bb98a7e479262c7eb25d5592545a3af147d there was the accidental
> deletion of a statement from call_sbin_request_key() to render the process
> keyring ID to a text string so that it can be passed to /sbin/request-key.
> 
> With gcc 4.6.0 this causes the following warning:
> 
>   CC      security/keys/request_key.o
> security/keys/request_key.c: In function 'call_sbin_request_key':
> security/keys/request_key.c:102:15: warning: variable 'prkey' set but not used
> 
> This patch reinstates that statement.
> 
> Without this statement, /sbin/request-key will get some random rubbish from the
> stack as that parameter.
> 
> Signed-off-by: Justin P. Mattock <justinmattock@...il.com>
> Signed-off-by: David Howells <dhowells@...hat.com>

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next


-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/