linux-kernel - Re: [patch] i915: take struct_mutex in i915_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fx0225du.fsf@pollan.anholt.net>
Date:	Thu, 01 Jul 2010 15:39:57 -0700
From:	Eric Anholt <eric@...olt.net>
To:	Dan Carpenter <error27@...il.com>, David Airlie <airlied@...ux.ie>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Chris Wilson <chris@...is-wilson.co.uk>,
	Zhenyu Wang <zhenyuw@...ux.intel.com>, nanhai.zou@...el.com,
	Benny Halevy <bhalevy@...asas.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] i915: take struct_mutex in i915_dma_cleanup()

On Wed, 23 Jun 2010 13:19:55 +0200, Dan Carpenter <error27@...il.com> wrote:
> intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as
> opposed to drm_gem_object_unreference_unlocked()) so it needs to be
> called with "struct_mutex" held.  If we don't hold the lock, it triggers
> a BUG_ON(!mutex_is_locked(&dev->struct_mutex));
> 
> I also audited the other places that call intel_cleanup_ring_buffer()
> and they all hold the lock so they're OK.
> 
> This was introduced in: 8187a2b70e3 "drm/i915: introduce
> intel_ring_buffer structure (V2)" and it's a regression from v2.6.34.
> 
> Addresses: https://bugzilla.kernel.org/show_bug.cgi?id=16247
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>
> Reported-by: Benny Halevy <bhalevy@...asas.com>
> Tested-by: Benny Halevy <bhalevy@...asas.com>

Applied to for-linus.  Thanks!

Content of type "application/pgp-signature" skipped