lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Jul 2010 09:09:37 +0100 From: Alexander Clouter <alex@...riz.org.uk> To: linux-kernel@...r.kernel.org Subject: Re: [PATCH] VMware balloon: force compiling as a module Dmitry Torokhov <dtor@...are.com> wrote: > >> > Now we have 2 drivers fighting. There is no backing device and so driver >> > core will not save us by refusing to bind to already claimed device. >> >> If vmware_balloon is present in /sys/modules or is loaded, don't load >> vmmemctl. And vice versa. >> >> I dunno - it's silly for me to sit here proposing solutions. it's >> better that you do it! > > Unfortunately I do not have a good solution at the moment. I guess we'll > have to work with distributions to make sure they keep it as a module > (it also makes most sense for them since not everyone runs on our > platform). > I cannot seriously believe you are considering a viable solution is "everyone[1] must abide by these rules otherwise our installer might barf". The only benefactor of this patch is your installer and the effect is an undocumented and peculiar constraint on a kernel module. Seriously, add sometime so that you get something in /sys/modules (maybe it's time for something in /sys/class?) or maybe do something so that you have: VMWARE_BALLOON_CMD(STATUS, ...) where the guest can say if there is already something ballooning for it. Surely the guest should be aware if there is more than one balloon driver at play? I think a friend of mine summed it up rather well: "Fixing the kernel instead of fixing the VMWare installer is an inspired move". Cheers [1] the dropdown menu on distrowatch lists 319 distrubutions -- Alexander Clouter .sigmonster says: May the bluebird of happiness twiddle your bits. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists