linux-kernel - Re: [PATCH 10/13] Do not try to disable hpet if it hasn't been initialized before

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C2DC327.1090007@redhat.com>
Date:	Fri, 02 Jul 2010 12:44:55 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	stefano@...bellini.net
CC:	linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com,
	Stefano.Stabellini@...citrix.com, sheng@...ux.intel.com,
	ddutile@...hat.com, jeremy@...p.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>
Subject: Re: [PATCH 10/13] Do not try to disable hpet if it hasn't been initialized
 before

On 06/21/2010 06:14 PM, stefano@...bellini.net wrote:
> -	if (is_hpet_capable()) {
> -		unsigned int cfg = hpet_readl(HPET_CFG);
> +	unsigned int cfg;

You changed this earlier from unsigned long to unsigned int, but it is 
wrong (though it works because bits 32-63 of the HPET_CFG register are 
unused).  Can you please make a note to change it back sometime?

Thanks,

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/