lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Jul 2010 12:48:24 +0200 From: Christoph Hellwig <hch@....de> To: Mike Snitzer <snitzer@...hat.com> Cc: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>, axboe@...nel.dk, hch@....de, James.Bottomley@...e.de, linux-scsi@...r.kernel.org, dm-devel@...hat.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] scsi: address leak in the error path of discard page allocation On Thu, Jul 01, 2010 at 09:03:28AM -0400, Mike Snitzer wrote: > On Thu, Jul 01 2010 at 6:49am -0400, > FUJITA Tomonori <fujita.tomonori@....ntt.co.jp> wrote: > > > This fixes discard page leak by using q->unprep_rq_fn facility. > > > > q->unprep_rq_fn is called when all the data buffer (req->bio and > > scsi_data_buffer) in the request is freed. > > > > sd_unprep() uses rq->buffer to free discard page allocated in > > sd_prepare_discard(). > > > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp> > > Thanks for sorting this out Tomo, all 3 patches work great! > > BTW, there is one remaining (rare) leak in the allocation path. > > The following patch serves to fix it but I'm not sure if there is a more > elegant way to address this. > > An alternative would be to check if the page is already allocated > (before allocating the page in scsi_setup_discard_cmnd)? Ah, should have read your mail first, sorry.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists