linux-kernel - Re: [PATCH/RFC] hwmon: Add support for W83667HG-B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100702161521.GA14580@ericsson.com>
Date:	Fri, 2 Jul 2010 09:15:21 -0700
From:	Guenter Roeck <guenter.roeck@...csson.com>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	Jim Cromie <jim.cromie@...il.com>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ethan Lawrence <e.law87@...oo.com>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lars4910@...mail.com" <lars4910@...mail.com>,
	"birdie@...monline.ru" <birdie@...monline.ru>,
	"jadcock@....net" <jadcock@....net>
Subject: Re: [PATCH/RFC] hwmon: Add support for W83667HG-B

On Fri, Jul 02, 2010 at 10:59:03AM -0400, Jean Delvare wrote:
> On Fri, 2 Jul 2010 07:09:44 -0700, Guenter Roeck wrote:
> > On Fri, Jul 02, 2010 at 05:51:23AM -0400, Jean Delvare wrote:
> > > On Fri, 2 Jul 2010 01:31:44 -0700, Guenter Roeck wrote:
> > > > On Fri, Jul 02, 2010 at 04:13:45AM -0400, Jean Delvare wrote:
> > > > > On Fri, 2 Jul 2010 01:07:04 -0700, Guenter Roeck wrote:
> > > > > > I'll also add a check for the HG-I.
> > > > > 
> > > > > Do you have a datasheet for that one too?
> > > > > 
> > > > No. However, since we have a tester, we will have test coverage,
> > > > so I figured it should be worth a try. If it doesn't work
> > > > I can still drop it from the final patch.
> > > 
> > > FYI, I have a datasheet, which unfortunately I am not allowed to share.
> > > Please let me know if you want me to look up something for you.
> > > 
> > How about the changed registers ? Would give us an idea if the chip is closer to 
> > 667 or to 667-B.
> 
> There is no summary of this available. The only way is to go through
> both datasheets and compare all registers in sequence. This takes time,
> which is exactly why I couldn't find the time to do it :(
> 
Yes, I noticed. Changes can be quite subtle, too. 

I'll remove the HG-I chip detection from the next patch rev
unless I manage to get a datasheet as well.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/