linux-kernel - Re: [PATCH] KVM: IOAPIC: only access APIC registers one dword at a time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C2D975A.2050704@cn.fujitsu.com>
Date:	Fri, 02 Jul 2010 15:38:02 +0800
From:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To:	Jin Dongming <jin.dongming@...css.fujitsu.com>
CC:	Avi Kivity <avi@...hat.com>, Marcelo Tosatti <mtosatti@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	KVM list <kvm@...r.kernel.org>
Subject: Re: [PATCH] KVM: IOAPIC: only access APIC registers one dword at
 a time



Jin Dongming wrote:

>>  
>>  	switch (len) {
>> -	case 8:
>> -		*(u64 *) val = result;
>> -		break;
>> -	case 1:
>> -	case 2:
>>  	case 4:
>> -		memcpy(val, (char *)&result, len);
> 
> Here the parameter len is not used for reading data from ioapic register, before switch case
> the value of ioapic register has been read by ioapic_read_indirect().
> 

Yeah, it's right, but it's rarely operation that guest using incorrect width to access
the registers, so i don't think it's worthy to move the width judgment before the real
registers read.

> 
>> +		*(u32 *) val = result;
>>  		break;
>> +
>>  	default:
>>  		printk(KERN_WARNING "ioapic: wrong length %d\n", len);
> 
> And I think here is not good to print warning message. Maybe it is better to do
> such kind of checking at the first of this function before ioapic_read_indirect().
> 

ditto

Thanks for your review, Jin!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/