linux-kernel - Re: [PATCH v2] fujitsu-laptop: remove unnecessary input_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100704083742.GF32427@core.coreip.homeip.net>
Date:	Sun, 4 Jul 2010 01:37:42 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Jonathan Woithe <jwoithe@...sics.adelaide.edu.au>
Cc:	Axel Lin <axel.lin@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Matthew Garrett <mjg@...hat.com>,
	Len Brown <len.brown@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Stefani Seibold <stefani@...bold.net>,
	Andi Kleen <ak@...ux.intel.com>,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2] fujitsu-laptop: remove unnecessary input_free_device

On Fri, Jul 02, 2010 at 05:05:02PM +0930, Jonathan Woithe wrote:
> Acked-by: Jonathan Woithe <jwoithe@...sics.adelaide.edu.au>

Looks good to me too.

Acked-by: Dmitry Torokhov <dtor@...l.ru>

>  
> > input_free_device should only be used if input_register_device()
> > was not called yet or if it failed.
> > This patch removes unnecessary input_free_device calls.
> > 
> > Signed-off-by: Axel Lin <axel.lin@...il.com>
> > ---
> >  drivers/platform/x86/fujitsu-laptop.c |    6 ++----
> >  1 files changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> > index e325aeb..4346d26 100644
> > --- a/drivers/platform/x86/fujitsu-laptop.c
> > +++ b/drivers/platform/x86/fujitsu-laptop.c
> > @@ -725,6 +725,7 @@ static int acpi_fujitsu_add(struct acpi_device *device)
> >  
> >  err_unregister_input_dev:
> >  	input_unregister_device(input);
> > +	input = NULL;
> >  err_free_input_dev:
> >  	input_free_device(input);
> >  err_stop:
> > @@ -738,8 +739,6 @@ static int acpi_fujitsu_remove(struct acpi_device *device, int type)
> >  
> >  	input_unregister_device(input);
> >  
> > -	input_free_device(input);
> > -
> >  	fujitsu->acpi_handle = NULL;
> >  
> >  	return 0;
> > @@ -930,6 +929,7 @@ static int acpi_fujitsu_hotkey_add(struct acpi_device *device)
> >  
> >  err_unregister_input_dev:
> >  	input_unregister_device(input);
> > +	input = NULL;
> >  err_free_input_dev:
> >  	input_free_device(input);
> >  err_free_fifo:
> > @@ -953,8 +953,6 @@ static int acpi_fujitsu_hotkey_remove(struct acpi_device *device, int type)
> >  
> >  	input_unregister_device(input);
> >  
> > -	input_free_device(input);
> > -
> >  	kfifo_free(&fujitsu_hotkey->fifo);
> >  
> >  	fujitsu_hotkey->acpi_handle = NULL;
> > -- 
> > 1.5.4.3
> > 
> > 
> > 
> 
> 
> -- 
> * Jonathan Woithe    jwoithe@...sics.adelaide.edu.au                        *
> *                    http://www.physics.adelaide.edu.au/~jwoithe            *
> ***-----------------------------------------------------------------------***
> ** "Time is an illusion; lunchtime doubly so"                              **
> *  "...you wouldn't recognize a subtle plan if it painted itself purple and *
> *   danced naked on a harpsichord singing 'subtle plans are here again'"    *
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/