| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1278346795.2229.2.camel@localhost> Date: Mon, 05 Jul 2010 12:19:55 -0400 From: Andy Walls <awalls@...metrocast.net> To: Jiri Slaby <jslaby@...e.cz> Cc: mchehab@...radead.org, linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>, Ian Armstrong <ian@...mst.demon.co.uk>, ivtv-devel@...vdriver.org, linux-media@...r.kernel.org Subject: Re: [PATCH] VIDEO: ivtvfb, remove unneeded NULL test On Mon, 2010-07-05 at 09:10 +0200, Jiri Slaby wrote: > On 07/04/2010 03:22 PM, Andy Walls wrote: > > On Sun, 2010-07-04 at 09:24 +0200, Jiri Slaby wrote: > >> On 07/04/2010 06:11 AM, Andy Walls wrote: > > There are windows of time where a struct device * will exist for a card > > in the ivtv driver, but a struct v4l2_device * may not: the end of > > ivtv_remove() and the beginning of ivtv_probe(). > > If there is no locking or refcounting, this won't change with the added > check. The window is still there, but it begins after the check with > your patch. Hence will still cause oopses. Jiri, Of course, you're absolutley right. Please resubmit a version of your original patch fixing both instances of the check. I'll add my ack and SOB. If any users ever report an Oops, then I'll bother to add interlocking. Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists