linux-kernel - Re: [PATCH v2 0/5] patches to settle i8042 with Intel MID platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C32364D.2040705@zytor.com>
Date:	Mon, 05 Jul 2010 12:45:17 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	feng.tang@...el.com
CC:	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...e.hu,
	jacob.jun.pan@...el.com, dtor@...l.ru, randy.dunlap@...cle.com
Subject: Re: [PATCH v2 0/5] patches to settle i8042 with Intel MID platforms

On 07/05/2010 08:03 AM, feng.tang@...el.com wrote:
> From: Feng Tang <feng.tang@...el.com>
> 
> Hi All,
> 
> Some x86 platforms like intel MID platforms don't have i8042 controllers,
> and i8042 driver's probe to some non-exist legacy IO ports may hang
> the MID processor. 
> 
> Current solution for this is add dependency of SERIO_I8042 over
> !X86_MRST, then if we build a x86 kernel image with X86_MRST=y,
> it won't have i8042 driver support over common x86 platforms.
> 
> So we add a i8042 pre-detect hook into x86_platforms ops, so that
> i8042 driver can use it to run-time judge whether to go on with
> probe process.
> 
> Please review these patches.
> 

Looks good to me.  Dmitry, what do you think?

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/