linux-kernel - Re: [PATCH 4/4] Staging: vme: devices: fix coding style issues in vme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C31A352.10807@ge.com>
Date:	Mon, 05 Jul 2010 10:18:10 +0100
From:	Martyn Welch <martyn.welch@...com>
To:	Gustavo Silva <silvagustavosilva@...il.com>
CC:	devel@...verdev.osuosl.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org,
	Gustavo Silva <silvagustavo@...rs.sourceforge.net>
Subject: Re: [PATCH 4/4] Staging: vme: devices: fix coding style issues in
 vme_user.c

Martyn Welch wrote:
> Gustavo Silva wrote:
>   
>> This is a patch to the vme_user.c file that fixes up the following
>> issues:
>>
>> WARNING: please, no space before tabs						x 12
>> ERROR: code indent should use tabs where possible				x 15
>> WARNING: braces {} are not necessary for single statement blocks		x  2
>> WARNING: printk() should include KERN_ facility level				x  3
>> ERROR: "foo * bar" should be "foo *bar"						x  1
>> ERROR: space required before the open brace '{'					x  3
>> WARNING: space prohibited between function name and open parenthesis '('	x  1
>> ERROR: spaces required around that '=' (ctx:VxV)				x  2
>> ERROR: spaces required around that '<' (ctx:VxV)				x  2
>> ERROR: space required after that ',' (ctx:VxV)					x  3
>> ERROR: spaces required around that '?' (ctx:VxW)				x  1
>> ERROR: space required before the open parenthesis '('				x  1
>> WARNING: braces {} are not necessary for single statement blocks		x  2
>>
>>   
>>     
>
> This looks very familiar - I'm sure there was a patch already on the
> mailing list doing this, but it has some issues which I don't think were
> ever addressed. This one looks good though.
>
>   
Hmm, seems the earlier patch was fixed up and is now in linux-next, sorry.

Martyn

-- 
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square, Manchester,
E martyn.welch@...com                        |   M2 3AB  VAT:GB 927559189

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/