linux-kernel - Re: [PATCH v5 4/9] KVM: MMU: introduce gfn_to_pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 06 Jul 2010 19:28:50 +0800
From:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To:	Gleb Natapov <gleb@...hat.com>
CC:	Avi Kivity <avi@...hat.com>, Marcelo Tosatti <mtosatti@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	KVM list <kvm@...r.kernel.org>
Subject: Re: [PATCH v5 4/9] KVM: MMU: introduce gfn_to_pfn_atomic() function



Gleb Natapov wrote:

>> +	}
>>  
>>  	if (unlikely(npages != 1)) {
>>  		struct vm_area_struct *vma;
>>  
>> +		if (atomic)
>> +			goto return_bad_page;
>> +
> You are skipping hwpoison test and sometimes you will return bad_page
> for something that returns good pfn now without caller even know.
> vma->vm_flags & VM_PFNMAP comes to mind. Is this safe?

No matter about it, we not hope the atomic case return good pfn all the time,
if the page is swapped or it's hwpoison just return bad_page, then we can skip
it in the speculative path.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/