linux-kernel - Re: [PATCH] cifs: remove unused ip_address field in struct TCP_Server

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTinmYDtq_eikwgjJSscRxJP9AvK9f2XD_tsFGtXC@mail.gmail.com>
Date:	Tue, 6 Jul 2010 13:22:08 -0500
From:	Steve French <smfrench@...il.com>
To:	Suresh Jayaraman <sjayaraman@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cifs: remove unused ip_address field in struct 
	TCP_Server_Info

Makes sense - plan to merge this and two others of yours into
cifs-2.6.git today or tomorrow.

On Tue, Jul 6, 2010 at 7:29 AM, Suresh Jayaraman <sjayaraman@...e.de> wrote:
> The ip_address field is not used and seems redundant as there is union addr
> already and I don't see any future use as well.
>
> Signed-off-by: Suresh Jayaraman <sjayaraman@...e.de>
> ---
>  fs/cifs/cifsglob.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index a88479c..f182fe8 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -142,7 +142,6 @@ struct TCP_Server_Info {
>        struct list_head pending_mid_q;
>        void *Server_NlsInfo;   /* BB - placeholder for future NLS info  */
>        unsigned short server_codepage; /* codepage for the server    */
> -       unsigned long ip_address;       /* IP addr for the server if known */
>        enum protocolEnum protocolType;
>        char versionMajor;
>        char versionMinor;
>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/