[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4C327DBA.9020309@cn.fujitsu.com>
Date: Tue, 06 Jul 2010 08:50:02 +0800
From: Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To: Marcelo Tosatti <mtosatti@...hat.com>
CC: Avi Kivity <avi@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
KVM list <kvm@...r.kernel.org>
Subject: Re: [PATCH v4 4/6] KVM: MMU: prefetch ptes when intercepted guest
#PF
Marcelo Tosatti wrote:
> On Sat, Jul 03, 2010 at 04:08:42PM +0800, Xiao Guangrong wrote:
>>
>> Marcelo Tosatti wrote:
>>
>>>> +
>>>> + if (is_rsvd_bits_set(vcpu, gpte, PT_PAGE_TABLE_LEVEL))
>>>> + break;
>>> BTW, doesnt sync_page also lack reserved bit checking? (unrelated to
>>> this patch).
>>>
>> I think it's not since if EPT is enabled, no unsync page exist, the sync page
>> path can't be trigged. :-)
>
> What i mean is, why the sync_page path does not require reserved bit
> checking? (EPT disabled).
>
Oh, i think we should check it, i'll post a patch to fix it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists