linux-kernel - Re: [PATCH v5 8/9] KVM: MMU: combine guest pte read between fetch and pte prefetch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Jul 2010 10:40:10 -0300
From:	Marcelo Tosatti <mtosatti@...hat.com>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
Cc:	Avi Kivity <avi@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
	KVM list <kvm@...r.kernel.org>
Subject: Re: [PATCH v5 8/9] KVM: MMU: combine guest pte read between fetch
 and pte prefetch

On Wed, Jul 07, 2010 at 09:11:56PM +0800, Xiao Guangrong wrote:
> 
> 
> Marcelo Tosatti wrote:
> 
> >>
> >> Below codes read gptes in the prefetch path:
> >>
> >> 	index = sptep - sp->spt;
> >> 	i = index & ~(PTE_PREFETCH_NUM - 1);
> >> 	max = index | (PTE_PREFETCH_NUM - 1);
> >>
> >> 	if (PTTYPE == 32)
> >> 		offset = sp->role.quadrant << PT64_LEVEL_BITS;
> >>
> >> 	first_pte_gpa = gfn_to_gpa(sp->gfn) +
> >> 				(offset + i) * sizeof(pt_element_t);
> >>
> >> 	if (kvm_read_guest_atomic(vcpu->kvm, first_pte_gpa, gptep,
> >> 					sizeof(gptep)) < 0)
> >> 		return;
> >>
> >> It reads the 16 aligned items around sptep's corresponding gpte and this gpte
> >> is also in this area. :-)
> > 
> > But you removed that in patch 8?
> > 
> 
> Oh, i just want it good for review, you mean it's better let patch 7 and 8 in one patch?

I mean patch 7 is wrong because it removes rereading of gpte, with
mmu_lock held, in the prefetch patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/