linux-kernel - Re: [PATCH -V14 04/11] vfs: Allow handle based open on symlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Jul 2010 02:48:59 +1000
From:	Nick Piggin <npiggin@...e.de>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	hch@...radead.org, viro@...iv.linux.org.uk, adilger@....com,
	corbet@....net, serue@...ibm.com, neilb@...e.de,
	hooanon05@...oo.co.jp, bfields@...ldses.org,
	linux-fsdevel@...r.kernel.org, sfrench@...ibm.com,
	philippe.deniel@....FR, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -V14 04/11] vfs: Allow handle based open on symlinks

On Tue, Jun 15, 2010 at 10:42:54PM +0530, Aneesh Kumar K.V wrote:
> The patch update may_open to allow handle based open on symlinks.
> The file handle based API use file descritor returned from open_by_handle_at
> to do different file system operations. To find the link target name we
> need to get a file descriptor on symlinks.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
> ---
>  fs/namei.c |   17 ++++++++++++++---
>  1 files changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/namei.c b/fs/namei.c
> index c2d19c7..417bf53 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -1422,7 +1422,7 @@ int vfs_create(struct inode *dir, struct dentry *dentry, int mode,
>  	return error;
>  }
>  
> -int may_open(struct path *path, int acc_mode, int flag)
> +static int __may_open(struct path *path, int acc_mode, int flag, int handle)
>  {
>  	struct dentry *dentry = path->dentry;
>  	struct inode *inode = dentry->d_inode;
> @@ -1433,7 +1433,13 @@ int may_open(struct path *path, int acc_mode, int flag)
>  
>  	switch (inode->i_mode & S_IFMT) {
>  	case S_IFLNK:
> -		return -ELOOP;
> +		/*
> +		 * For file handle based open we should allow
> +		 * open of symlink.
> +		 */
> +		if (!handle)
> +			return -ELOOP;
> +		break;
>  	case S_IFDIR:
>  		if (acc_mode & MAY_WRITE)
>  			return -EISDIR;
> @@ -1473,6 +1479,11 @@ int may_open(struct path *path, int acc_mode, int flag)
>  	return break_lease(inode, flag);
>  }
>  
> +int may_open(struct path *path, int acc_mode, int flag)
> +{
> +	return __may_open(path, acc_mode, flag, 0);
> +}

Why don't you just add MAY_OPEN_LNK instead of this ugliness?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/