linux-kernel - Re: [PATCH] time/fs - file's time race with vgettimeofday

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 07 Jul 2010 10:20:30 -0700
From:	john stultz <johnstul@...ibm.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de,
	eric.dumazet@...il.com, oleg@...hat.com
Subject: Re: [PATCH] time/fs - file's time race with vgettimeofday

On Wed, 2010-07-07 at 19:11 +0200, Jiri Olsa wrote:
> On Tue, Jul 06, 2010 at 04:11:40PM -0700, john stultz wrote:
> > -	vgettimeofday(&tv, NULL);
> > -	result = tv.tv_sec;
> > +	do {
> > +		seq = read_seqbegin(&__vsyscall_gtod_data.lock);
> > +
> > +		result = vsyscall_gtod_data.wall_time_sec;
> > +
> > +	} while (read_seqretry(&__vsyscall_gtod_data.lock, seq));
> > +
> >  	if (t)
> >  		*t = result;
> >  	return result;
> > 
> > 
> 
> I think there's a typo in using "vsyscall_gtod_data" inside
> the vtime call it should be "__vsyscall_gtod_data" intead.

Quite right! Thanks for catching it!
-john


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/