[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 7 Jul 2010 19:58:29 -0400
From: Christoph Hellwig <hch@...radead.org>
To: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc: hch@...radead.org, axboe@...nel.dk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/9] remove q->prepare_flush_fn hook
On Thu, Jul 08, 2010 at 08:54:59AM +0900, FUJITA Tomonori wrote:
> On Wed, 7 Jul 2010 15:52:09 -0400
> Christoph Hellwig <hch@...radead.org> wrote:
>
> > One weird thing after this set is that the flush commands don't have any
> > cmd_type. I think it should be set to REQ_TYPE_FS, even if we might be
> > resetting it inside the driver for now.
>
> I think even before this patchset, the block layer doesn't set
> rq->cmd_type on flush requests (scsi and Ode sets it in
> prepare_flush_fn).
Indeed it didn't. But before that it matters less because
prepare_flush_fn set it before the command entered prep_fn.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists