linux-kernel - Re: [PATCH] acerhdf: make needlessly global symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Jul 2010 11:08:36 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Peter Feuerer <peter@...e.net>,
	Matthew Garrett <mjg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Borislav Petkov <petkovbb@...il.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] acerhdf: make needlessly global symbols static

From: Axel Lin <axel.lin@...il.com>
Date: Thu, Jul 08, 2010 at 09:46:20AM +0800

> The following symbols are needlessly defined global:
> 
> thz_dev
> cl_dev
> acerhdf_dev
> acerhdf_dev_ops
> acerhdf_cooling_ops
> 
> This patch makes the symbols static.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Acked-by: Borislav Petkov <bp@...en8.de>

> ---
>  drivers/platform/x86/acerhdf.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index 7b2384d..5caaaf0 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -92,9 +92,9 @@ static unsigned int fanstate = ACERHDF_FAN_AUTO;
>  static char force_bios[16];
>  static char force_product[16];
>  static unsigned int prev_interval;
> -struct thermal_zone_device *thz_dev;
> -struct thermal_cooling_device *cl_dev;
> -struct platform_device *acerhdf_dev;
> +static struct thermal_zone_device *thz_dev;
> +static struct thermal_cooling_device *cl_dev;
> +static struct platform_device *acerhdf_dev;
>  
>  module_param(kernelmode, uint, 0);
>  MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off");
> @@ -374,7 +374,7 @@ static int acerhdf_get_crit_temp(struct thermal_zone_device *thermal,
>  }
>  
>  /* bind callback functions to thermalzone */
> -struct thermal_zone_device_ops acerhdf_dev_ops = {
> +static struct thermal_zone_device_ops acerhdf_dev_ops = {
>  	.bind = acerhdf_bind,
>  	.unbind = acerhdf_unbind,
>  	.get_temp = acerhdf_get_ec_temp,
> @@ -449,7 +449,7 @@ err_out:
>  }
>  
>  /* bind fan callbacks to fan device */
> -struct thermal_cooling_device_ops acerhdf_cooling_ops = {
> +static struct thermal_cooling_device_ops acerhdf_cooling_ops = {
>  	.get_max_state = acerhdf_get_max_state,
>  	.get_cur_state = acerhdf_get_cur_state,
>  	.set_cur_state = acerhdf_set_cur_state,
> -- 
> 1.5.4.3
> 
> 
> 

-- 
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/