lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 07 Jul 2010 18:18:47 -0700 (PDT) From: David Miller <davem@...emloft.net> To: sfr@...b.auug.org.au Cc: netdev@...r.kernel.org, linux-next@...r.kernel.org, linux-kernel@...r.kernel.org, joe@...ches.com, gregkh@...e.de Subject: Re: linux-next: build warning after merge of the net tree From: David Miller <davem@...emloft.net> Date: Wed, 07 Jul 2010 17:45:22 -0700 (PDT) > From: Stephen Rothwell <sfr@...b.auug.org.au> > Date: Tue, 6 Jul 2010 14:25:42 +1000 > >> After merging the net tree, today's linux-next build (powerpc >> ppc64_defconfig) produced these warnings: >> >> drivers/scsi/sym53c8xx_2/sym_hipd.c: In function 'sym_print_msg': >> drivers/scsi/sym53c8xx_2/sym_hipd.c:78: warning: zero-length gnu_printf format string > > Thanks Stephen I'll look into this. Yeah this is a bit ugly. It used to be that the dev_*() format string was CPP pasted to whatever format string the user gave. So if the user gave an empty string it still looked like a non-empty printf string. But that no longer happens because we hide the implementation, and thus the top-level printf format string, in the external functions. It seems the construction: /* * Stupid hackaround for existing uses of non-printk uses dev_info * * Note that the definition of dev_info below is actually _dev_info * and a macro is used to avoid redefining dev_info */ #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg) added to linux/device.h was meant to handle these cases, but as we see it doesn't. It looks like there are just a hand-ful of cases, so maybe we can tweak them by hand. For example, in the sym53c8xx_2 driver bits we can replace the NULL labels passed to sym_print_msg() with a real string and therefore remove the "" case. Joe, any better ideas? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists