linux-kernel - Re: [PATCH 18/18] vfs: make no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201007081408.06415.arnd@arndb.de>
Date:	Thu, 8 Jul 2010 14:08:06 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH 18/18] vfs: make no_llseek the default

On Thursday 08 July 2010, Tetsuo Handa wrote:
> Hello.
> 
> Arnd Bergmann wrote:
> > All file operations now have an explicit .llseek
> > operation pointer, so we can change the default
> > action for future code.
> 
> I saw patch for SELinux and IMA, but not for TOMOYO.
> TOMOYO has
> 
>   static const struct file_operations tomoyo_operations
> 
> without .llseek operation pointer.
> 
> TOMOYO does not deal offset pointer. Thus seek operation makes
> no sense. But returning -ESPIPE for seek operation might break
> some applications. What should I do for TOMOYO?

The semantic patch (16/18 in this series) had detected that case,
so I did not have to manually create a patch as for selinux
and ima.

The behaviour you want is noop_llseek, which is what gets used
when the semantic patch is applied. If you wish, you can
do the patch yourself and add .llseek = noop_llseek to the file
operations in your tree.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/